Improve StrSplit returnType #3999
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
strSplit
branch
2 times, most recently
from
fff96fc to
8764aad
Compare
|
If it's ok, I opened #4000 first |
VincentLanglet
force-pushed
the
strSplit
branch
3 times, most recently
from
7a7038b to
4cb2211
Compare
VincentLanglet
force-pushed
the
strSplit
branch
7 times, most recently
from
b4969b9 to
5819f3b
Compare
|
This pull request has been marked as ready for review. |
VincentLanglet
commented
Jun 13, 2025
| foreach ($constantStrings as $constantString) { | ||
| $value = $constantString->getValue(); | ||
|
|
||
| if ($encoding === null && $value === '') { |
There was a problem hiding this comment.
This logic exists to avoid the same issue than phpstan/phpstan#13129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @herndlm
I saw you worked multiple times on this extension with
str_split/mb_str_splitstring arg compound types + default return type formb_str_split#1496str_splitreturns an empty array since PHP 8.2 #1544So you might want to review this.
I still need to update the LegacyNodeScopeResolverTest.
@ondrejmirtes Do you want me to fix the LegacyNodeScopeResolverTest as if, or would it be ok to migrate them inside the new NodeScopeResolverTest instead ?